rebase #288
rebase #288
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…eware-generic-support_issue_1603 RDKEMW-7169 - Auto PR for rdkcentral/meta-middleware-generic-support 1603
…ideo_issue_1649 RDKEMW-8168 - Auto PR for rdkcentral/meta-rdk-video 1649
…ideo_issue_1654 RDKEMW-8201 - Auto PR for rdkcentral/meta-rdk-video 1654
…eware-generic-support_issue_1485 RDKEMW-4216 - Auto PR for rdkcentral/meta-middleware-generic-support 1485
RDKEMW-8405 - Auto PR for rdkcentral/meta-rdk-video 1670
…eware-generic-support_issue_1651 RDKEMW-8317 - Auto PR for rdkcentral/meta-middleware-generic-support 1651
RDKEMW-8299 - Auto PR for rdkcentral/meta-rdk-video 1633
…eware-generic-support_issue_1667 RDKEMW-8370 - Auto PR for rdkcentral/meta-middleware-generic-support 1667
…ideo_issue_1673 RDKEMW-7761 - Auto PR for rdkcentral/meta-rdk-video 1673
…ideo_issue_1665 RDKEMW-7133 - Auto PR for rdkcentral/meta-rdk-video 1665
…eware-generic-support_issue_1648 NO-TICKET - Auto PR for rdkcentral/meta-middleware-generic-support 1648
…eware-generic-support_issue_1354 RDKEMW-5405 - Auto PR for rdkcentral/meta-middleware-generic-support 1354
…eware-generic-support_issue_2023 RDKEMW-9824 - Auto PR for rdkcentral/meta-middleware-generic-support 2023
…ideo_issue_1959 RDKEMW-9961 - Auto PR for rdkcentral/meta-rdk-video 1959
…ic-support_pr_2083 RDK-59748 - Auto PR for rdkcentral/meta-middleware-generic-support 2083
…ideo_issue_1963 RDKEMW-9716 - Auto PR for rdkcentral/meta-rdk-video 1963
…ideo_issue_1960 RDKEMW-10017 - Auto PR for rdkcentral/meta-rdk-video 1960
…ideo_issue_1699 RDKEMW-8491 - Auto PR for rdkcentral/meta-rdk-video 1699
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| > 25 March 2025 | ||
|
|
||
| #### [1.11.0](https://github.com/rdkcentral/rdke-middleware-generic-manifest/compare/1.10.0...1.11.0) | ||
|
|
||
| > 8 October 2025 |
There was a problem hiding this comment.
Date inconsistency: Version 2.8.0-test2 is dated 25 March 2025, but version 1.11.0 (which is compared from 2.8.0-test2) is dated 8 October 2025. This creates a timeline where an older version (2.8.0-test2) is released before a newer version (1.11.0), which is chronologically backward. The dates should be reviewed to ensure they align with the actual release timeline.
| > 8 October 2025 | |
| > 24 March 2025 |
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | ||
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | ||
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | ||
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
There was a problem hiding this comment.
Inconsistent indentation: Lines 16-19 use 8 spaces for indentation while the rest of the file uses 2 or 4 spaces. The secrets: block should use consistent indentation (either 4 or 6 spaces to align with the uses: line above).
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} | |
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
There was a problem hiding this comment.
Inconsistent spacing in validation summary output. Line 102 has an extra space before "FAILED" ( FAILED) while line 103 does not have the extra space (FAILED). This inconsistency will cause the output to be misaligned.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
| types: [labeled] | ||
| branches: | ||
| - develop | ||
| - 'support/*.*.*' |
There was a problem hiding this comment.
The branch pattern 'support/*.*.*' only matches support branches with exactly three dot-separated segments (e.g., support/1.2.3). If support branches use different patterns like support/2.16.0 or support/8.3.4.0 (four segments), they won't match. Consider using 'support/**' to match all support branches regardless of versioning scheme, or verify that the pattern matches the actual branch naming convention used in the repository.
| - 'support/*.*.*' | |
| - 'support/**' |
| @@ -4,8 +4,372 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
|
|
|||
| #### [1.4.0](https://github.com/rdkcentral/rdke-middleware-generic-manifest/compare/2.8.0-test4...1.4.0) | |||
| #### [1.12.0](https://github.com/rdkcentral/rdke-middleware-generic-manifest/compare/2.8.0-test4...1.12.0) | |||
There was a problem hiding this comment.
The version comparison in the changelog header is inconsistent with semantic versioning. Version 1.12.0 is being compared to 2.8.0-test4, which creates a confusing comparison since 2.8.0 is numerically higher than 1.12.0. This appears to be a version rollback or incorrect version sequencing. The changelog should compare consecutive versions (e.g., 1.12.0 compared to 1.11.0).
RDKEMW-9859 - Auto PR for rdkcentral/meta-rdk 324
…ssue_327 RDKEMW-6710 - Auto PR for rdkcentral/meta-rdk 327
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
The checkout action is used but the repository code is not needed for this validation workflow. The workflow only validates PR metadata (title and body) from GitHub context variables. Consider removing this unnecessary step to improve workflow efficiency.
| - name: Checkout code | |
| uses: actions/checkout@v4 |
…eware-generic-support_issue_2093 RDKEMW-9458 - Auto PR for rdkcentral/meta-middleware-generic-support 2093
…ssue_286 RDKEMW-10174 - Auto PR for rdkcentral/meta-rdk 286
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
There was a problem hiding this comment.
Inconsistent spacing in output messages. The 'FAILED' case for PR Title has an extra leading space (' FAILED'), while the PR Description outputs 'PASSED' and 'FAILED' without extra spaces. This should be consistent.
| <annotation name="MANIFEST_EXPORT_PATH" value="MANIFEST_PATH_RDK_VIDEO" /> | ||
| </project> | ||
|
|
||
| <project groups="rdk" name="meta-clang" path="rdke/common/meta-clang" remote="rdkcentral" revision="kirkstone"> |
There was a problem hiding this comment.
Using a branch name ('kirkstone') as the revision instead of a specific commit hash is inconsistent with other projects in this manifest that use commit hashes. This makes builds less reproducible and could lead to unexpected changes. Consider using a specific commit hash from the kirkstone branch.
| <project groups="rdk" name="meta-clang" path="rdke/common/meta-clang" remote="rdkcentral" revision="kirkstone"> | |
| <project groups="rdk" name="meta-clang" path="rdke/common/meta-clang" remote="rdkcentral" revision="e3b1c2d4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0"> |
No description provided.